Windows cfapi backend for vfs #2778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
December 30, 2020 09:44
Signed-off-by: Kevin Ottens <[email protected]>
Signed-off-by: Kevin Ottens <[email protected]>
For now this implements only the logic necessary to get a test suite equivalent to the TestSyncVirtualFiles one to pass. It doesn't (yet) honor request to fetch files from the system. Signed-off-by: Kevin Ottens <[email protected]>
Signed-off-by: Kevin Ottens <[email protected]>
This reduces code duplication and opportunities of mistakes between the test and the implementation. Signed-off-by: Kevin Ottens <[email protected]>
Since we often checked the same file states to see if they were virtual, non virtual or gone, let's factor this out. This way intent in tests is clearer. Signed-off-by: Kevin Ottens <[email protected]>
This comes with a test simulating an open request coming from another process (although in our case it's really just a thread). The actual hydration works as expected by cfapi, handling of encrypted files is for now missing. Signed-off-by: Kevin Ottens <[email protected]>
Otherwise this would attempt to download the file everytime we check the direct editor for a given file which wouldn't be adequate. Would also lead to a deadlock in our case since that would happen in the main thread and implicit hydration is driven from there as well. Signed-off-by: Kevin Ottens <[email protected]>
Signed-off-by: Kevin Ottens <[email protected]>
er-vin
requested review from
sbeyer,
camilasan,
allexzander and
DominiqueFuchs
|
AppImage file: Nextcloud-PR-2778-46a5bd6b253751db1a5db9f2603cd3724de4fb6a-x86_64.AppImage |
allexzander
approved these changes
Dec 30, 2020
|
@er-vin is there a beta version for windows for this feature so we can test ? |
|
@axheli It's enabled in the latest pre release. You can download it here: |
|
@FlexW Thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduce a test suite and a minimal backend for CfAPI support on Windows when the VFS is used. So far it seems to do the job all the way to implicit hydration. Some integration with the system could be improved (like status emblem on icons) but better keep this for later iterations on the feature, let's stabilize and QA what's in there.
Fix #2637
Fix #1951